Issue 337040: [mac] Fix Cmd-w in the one-tab case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337040: [mac] Fix Cmd-w in the one-tab case. (Closed)

Created:
11 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

[mac] Fix Cmd-w in the one-tab case. BUG=25788 TEST=See bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30209

Patch Set 1 #

Patch Set 2 : heh #

Total comments: 1

Patch Set 3 : Add comment #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/browser_window_cocoa.mm	View	1 2	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

11 years, 1 month ago (2009-10-27 05:11:26 UTC) #2

LGTM with some more comments.

http://codereview.chromium.org/337040/diff/2001/3001
File chrome/browser/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/337040/diff/2001/3001#newcode368
Line 368: // "Close window" doesn't use the |commandDispatch:| mechanism.
For want of a better mechanism, I guess this is okay. Could you provide more
comments on why (a) it's important to return IDC_CLOSE_WINDOW here, but (b) it's
okay to ignore, e.g., the Edit menu items?

It'd probably also be good for your comment to point to
|Browser::IsReservedAccelerator()|. It might also be good to have a
(Mac-specific) comment in the latter to here -- in case a reserved accelerator
is ever added. That comment could also explain the limitations of the current
mechanism (i.e., if a Mac accelerator doesn't have an IDC_..., we can't make it
"reserved").

Expand Messages | Collapse Messages