Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5056)

Unified Diff: chrome/common/extensions/extension.cc

Issue 337035: Replace ExtensionAction with ExtensionAction2. (Closed)
Patch Set: Remove todo Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc
index 2fae2abecce8b91c1a936bacf78cb22f81bac340..c7207c12a776d9826134658ac4d22fd219e76d63 100644
--- a/chrome/common/extensions/extension.cc
+++ b/chrome/common/extensions/extension.cc
@@ -297,14 +297,14 @@ bool Extension::LoadUserScriptHelper(const DictionaryValue* content_script,
return true;
}
-ExtensionAction2* Extension::LoadExtensionAction2Helper(
+ExtensionAction* Extension::LoadExtensionActionHelper(
const DictionaryValue* extension_action, std::string* error) {
- scoped_ptr<ExtensionAction2> result(new ExtensionAction2());
+ scoped_ptr<ExtensionAction> result(new ExtensionAction());
result->set_extension_id(id());
// Page actions are hidden by default, and browser actions ignore
// visibility.
- result->SetIsVisible(ExtensionAction2::kDefaultTabId, false);
+ result->SetIsVisible(ExtensionAction::kDefaultTabId, false);
// TODO(EXTENSIONS_DEPRECATED): icons list is obsolete.
ListValue* icons = NULL;
@@ -351,7 +351,7 @@ ExtensionAction2* Extension::LoadExtensionAction2Helper(
*error = errors::kInvalidPageActionDefaultTitle;
return NULL;
}
- result->SetTitle(ExtensionAction2::kDefaultTabId, title);
+ result->SetTitle(ExtensionAction::kDefaultTabId, title);
// Read the action's |popup| (optional).
DictionaryValue* popup = NULL;
@@ -946,7 +946,7 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id,
}
page_action_.reset(
- LoadExtensionAction2Helper(page_action_value, error));
+ LoadExtensionActionHelper(page_action_value, error));
if (!page_action_.get())
return false; // Failed to parse page action definition.
} else if (source.HasKey(keys::kPageAction)) {
@@ -957,7 +957,7 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id,
}
page_action_.reset(
- LoadExtensionAction2Helper(page_action_value, error));
+ LoadExtensionActionHelper(page_action_value, error));
if (!page_action_.get())
return false; // Failed to parse page action definition.
}
@@ -977,7 +977,7 @@ bool Extension::InitFromValue(const DictionaryValue& source, bool require_id,
}
browser_action_.reset(
- LoadExtensionAction2Helper(browser_action_value, error));
+ LoadExtensionActionHelper(browser_action_value, error));
if (!browser_action_.get())
return false; // Failed to parse browser action definition.
}
« no previous file with comments | « chrome/common/extensions/extension.h ('k') | chrome/common/extensions/extension_action.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698