Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337034: Remove the browser_sync flag. (Closed)

Created:
11 years, 1 month ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove the browser_sync flag. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30272

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -694 lines) Patch
M chrome/browser/automation/automation_profile_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/browser.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 3 4 5 6 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/browser_about_handler.cc View 1 2 3 4 5 6 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_page_sync_handler.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_page_sync_handler.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.h View 1 2 3 4 5 6 4 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.cc View 1 2 3 4 5 6 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/gtk/standard_menus.cc View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profile.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profile.cc View 1 2 3 4 5 6 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_worker.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_worker.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_worker_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/change_processor.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 3 4 5 6 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_setup_wizard_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_status_ui_helper.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/sync_status_ui_helper.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.h View 1 2 3 4 5 6 4 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 1 2 3 4 5 6 15 chunks +0 lines, -28 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.h View 1 2 3 4 5 6 5 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/views/bookmark_manager_view.cc View 1 2 3 4 5 6 10 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/views/options/content_page_view.h View 1 2 3 4 5 6 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 2 3 4 5 6 12 chunks +2 lines, -23 lines 0 comments Download
M chrome/browser/views/toolbar_view.cc View 1 2 3 4 5 6 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 6 chunks +404 lines, -424 lines 0 comments Download
M chrome/test/live_sync/bookmark_model_verifier.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/live_sync/bookmark_model_verifier.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/live_sync/live_bookmarks_sync_test.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/live_sync/live_bookmarks_sync_test.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/live_sync/profile_sync_service_test_harness.h View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/live_sync/profile_sync_service_test_harness.cc View 1 2 3 4 5 6 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/test/live_sync/single_client_live_bookmarks_sync_unittest.cc View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 1 2 3 4 5 6 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/sync/test_http_bridge_factory.h View 1 2 3 4 5 6 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/test/testing_profile.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/testing_profile.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zachary Kuznia
11 years, 1 month ago (2009-10-27 17:59:56 UTC) #1
ncarter (slow)
11 years, 1 month ago (2009-10-27 18:50:32 UTC) #2 
LGTM!

I'm slightly worry is the two or three places where we used to do:
#if defined(BROWSER_SYNC) && !defined(OS_POSIX)

and now we do:
#if !defined(OS_POSIX)

These locations are now less greppable.  But there are sufficiently few that I'm
not incredibly worried.

Powered by Google App Engine
This is Rietveld 408576698