Issue 337033: FilePath::Append() doesn't allow you to append a fully-qualified...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 337033: FilePath::Append() doesn't allow you to append a fully-qualified... (Closed)

Created:
11 years, 1 month ago by Mike Belshe

Modified:
9 years, 5 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org, yezhang_google.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

FilePath::Append() doesn't allow you to append a fully-qualified path (like "C:\foo\bar"). The current code was attempting to append "c:\foo\bar" to "\\?\" for long filename support. Reworked so that this could work. I feel back about using the ToWStringHack() function, but there is literally no other choice. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30206

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	net/tools/dump_cache/cache_dumper.cc	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages