[Mac] Adjust Omnibox implementation to not break undo chain.

[Mac] Adjust Omnibox implementation to not break undo chain.

This does not fix undo, it just makes the implementation break it
less.

BUG=18084
TEST=Omnibox should continue to work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30071

[Scott Hess - ex-Googler, 2009-10-26 18:32:16]

Here you go, even tests that it doesn't break undo (I think).

[rohitrao (ping after 24h), 2009-10-26 18:56:01]

LGTM

This looks pretty much the same as your original idea, just structured nicely
instead of shoved into AutocompleteEditViewMac.

I think when I go through and put in my custom undomanager code, undo should
work nicely.

http://codereview.chromium.org/337027/diff/1/5
File chrome/browser/cocoa/autocomplete_text_field_unittest.mm (right):

http://codereview.chromium.org/337027/diff/1/5#newcode590
Line 590: // Get a font different from the field's default font.
Why is the font important?

[Scott Hess - ex-Googler, 2009-10-26 19:11:57]

http://codereview.chromium.org/337027/diff/1/5
File chrome/browser/cocoa/autocomplete_text_field_unittest.mm (right):

http://codereview.chromium.org/337027/diff/1/5#newcode590
Line 590: // Get a font different from the field's default font.
On 2009/10/26 18:56:02, rohitrao wrote:
> Why is the font important?

The font is immaterial, just wanted to make sure that the string being pushed in
differed materially from the field's defaults so that when I pull it out things
don't match coincidentally.  I'll try to augment the comment a bit.