Don't scale up small browser action icons....

Don't scale up small browser action icons.

When creating the canvas, take cues from the image we
just loaded and don't hard code it to 19x19. This way
we can have smaller than 19x19 icons that show up
centered within the browser icon button.

This doesn't attempt to deal with scaling down images
that are too large to fit the 19x19 canvas, but we
haven't decided how to handle those anyway.

BUG=25487
TEST=Load the api_test/browser_action_tab_specific_state
extension and click on the browser action. The red
square within the button should not grow in size as you
click.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30072

[Aaron Boodman, 2009-10-26 18:23:43]

http://codereview.chromium.org/337026/diff/1/2
File chrome/renderer/resources/extension_process_bindings.js (right):

http://codereview.chromium.org/337026/diff/1/2#newcode373
Line 373: if (!canvas) {
It looks like there is no need to cache these context variables -- we can just
create them each time and let them get GC'd.

That way, we won't end up with mismatched sizes if a second call has an icon
that is a different size than the first.

[Finnur, 2009-10-26 18:36:06]

New patch uploaded.

[Aaron Boodman, 2009-10-26 18:45:48]

lgtm