Attempt at fixing crash. The latest crash indicates the user is...

chrome/browser/views/tabs/tab_strip.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/tabs/tab_strip.h"
 
 #include "app/drag_drop_types.h"
 #include "app/gfx/canvas.h"
 #include "app/gfx/path.h"
 #include "app/l10n_util.h"
@@ skipping 1014 matching lines @@
   // Don't animate the first tab, it looks weird, and don't animate anything
   // if the containing window isn't visible yet.
   if (GetTabCount() > 1 && GetWindow() && GetWindow()->IsVisible()) {
     StartInsertTabAnimation(index);
   } else {
     Layout();
   }
 }
 
 void TabStrip::TabDetachedAt(TabContents* contents, int index) {
-  if (CanUpdateDisplay()) {
-    GenerateIdealBounds();
-    StartRemoveTabAnimation(index, contents);
-    // Have to do this _after_ calling StartRemoveTabAnimation, so that any
-    // previous remove is completed fully and index is valid in sync with the
-    // model index.
-    GetTabAt(index)->set_closing(true);
-  }
+  GenerateIdealBounds();
+  StartRemoveTabAnimation(index, contents);
+  // Have to do this _after_ calling StartRemoveTabAnimation, so that any
+  // previous remove is completed fully and index is valid in sync with the
+  // model index.
+  GetTabAt(index)->set_closing(true);
 }
 
 void TabStrip::TabSelectedAt(TabContents* old_contents,
                              TabContents* new_contents,
                              int index,
                              bool user_gesture) {
   DCHECK(index >= 0 && index < GetTabCount());
-  if (CanUpdateDisplay()) {
-    // We have "tiny tabs" if the tabs are so tiny that the unselected ones are
-    // a different size to the selected ones.
-    bool tiny_tabs = current_unselected_width_ != current_selected_width_;
-    if (!IsAnimating() && (!resize_layout_scheduled_ || tiny_tabs)) {
-      Layout();
-    } else {
-      SchedulePaint();
-    }
+  // We have "tiny tabs" if the tabs are so tiny that the unselected ones are
+  // a different size to the selected ones.
+  bool tiny_tabs = current_unselected_width_ != current_selected_width_;
+  if (!IsAnimating() && (!resize_layout_scheduled_ || tiny_tabs)) {
+    Layout();
+  } else {
+    SchedulePaint();
+  }
 
-    int old_index = model_->GetIndexOfTabContents(old_contents);
-    if (old_index >= 0)
-      GetTabAt(old_index)->StopPinnedTabTitleAnimation();
-  }
+  int old_index = model_->GetIndexOfTabContents(old_contents);
+  if (old_index >= 0)
+    GetTabAt(old_index)->StopPinnedTabTitleAnimation();
 }
 
 void TabStrip::TabMoved(TabContents* contents, int from_index, int to_index,
                         bool pinned_state_changed) {
   gfx::Rect start_bounds = GetIdealBounds(from_index);
   Tab* tab = GetTabAt(from_index);
   tab_data_.erase(tab_data_.begin() + from_index);
   TabData data = {tab, gfx::Rect()};
   tab->set_pinned(model_->IsTabPinned(to_index));
   tab_data_.insert(tab_data_.begin() + to_index, data);
@@ skipping 127 matching lines @@
   // so the View system can misinterpret this easily if the mouse is down that
   // the user is dragging.
   if (IsAnimating() || tab->closing() || !HasAvailableDragActions())
     return;
   int index = GetIndexOfTab(tab);
   if (!model_->ContainsIndex(index)) {
     // It appears to be possible for a drag to start with an invalid tab.
     // This records some extra information in hopes of tracking down why.
     // The string contains the following, in order:
     // . If a drag is already in progress, a 'D'.
+    // . If the model is closing all, an 'A'.
     // . Index of tab the user is dragging.
     // . Number of tabs.
     // . Size of the model.
     // . Indices of any tabs that are being closed.
     // . ! end marker.
     std::string tmp;
     if (drag_controller_.get())
       tmp += "D";
+    if (model_->closing_all())
+      tmp += " A";
     tmp += " " + IntToString(index);
     tmp += " " + IntToString(GetTabCount());
     tmp += " " + IntToString(model_->count());
     for (int i = 0; i < GetTabCount(); ++i) {
       if (GetTabAt(i)->closing())
         tmp += " " + IntToString(i);
     }
     tmp += "!";  // End marker so we know we got all closing tabs.
 
     volatile char tab_state[128];
@@ skipping 670 matching lines @@
 void TabStrip::StartPinAndMoveTabAnimation(int from_index,
                                            int to_index,
                                            const gfx::Rect& start_bounds) {
   if (active_animation_.get())
     active_animation_->Stop();
   active_animation_.reset(
       new PinAndMoveAnimation(this, from_index, to_index, start_bounds));
   active_animation_->Start();
 }
 
-bool TabStrip::CanUpdateDisplay() {
-  // Don't bother laying out/painting when we're closing all tabs.
-  if (model_->closing_all()) {
-    // Make sure any active animation is ended, too.
-    if (active_animation_.get())
-      active_animation_->Stop();
-    return false;
-  }
-  return true;
-}
-
 void TabStrip::FinishAnimation(TabStrip::TabAnimation* animation,
                                bool layout) {
   active_animation_.reset(NULL);
 
   // Reset the animation state of each tab.
   for (int i = 0, count = GetTabCount(); i < count; ++i)
     GetTabAt(i)->set_animating_pinned_change(false);
 
   if (layout)
     Layout();
@@ skipping 60 matching lines @@
               &TabStrip::ResizeLayoutTabs),
           kResizeTabsTimeMs);
     }
   } else {
     // Mouse moved quickly out of the tab strip and then into it again, so
     // cancel the timer so that the strip doesn't move when the mouse moves
     // back over it.
     resize_layout_factory_.RevokeAll();
   }
 }