NTP: Allow hiding tips and bookmark sync....

chrome/browser/resources/new_new_tab.js

 
 // Helpers
 
 // TODO(arv): Remove these when classList is available in HTML5.
 // https://bugs.webkit.org/show_bug.cgi?id=20709
 function hasClass(el, name) {
   return el.nodeType == 1 && el.className.split(/\s+/).indexOf(name) != -1;
 }
 
 function addClass(el, name) {
-  el.className += ' ' + name;
+  var names = el.className.split(/\s+/);
+  if (names.indexOf(name) == -1) {
+    el.className += ' ' + name;
+  }
 }
 
 function removeClass(el, name) {
   var names = el.className.split(/\s+/);
   el.className = names.filter(function(n) {
     return name != n;
   }).join(' ');
 }
 
 function findAncestorByClass(el, className) {
@@ skipping 268 matching lines @@
 }
 
 function showSection(section) {
   if (!(section & shownSections)) {
     shownSections |= section;
 
     // THUMBS and LIST are mutually exclusive.
     if (section == Section.THUMB) {
       // hide LIST
       shownSections &= ~Section.LIST;
-      mostVisited.invalidate();
     } else if (section == Section.LIST) {
       // hide THUMB
       shownSections &= ~Section.THUMB;
-      mostVisited.invalidate();
-    } else {
-      renderRecentlyClosed();
     }
-
-    mostVisited.updateDisplayMode();
-    mostVisited.layout();
+    switch (section) {
+      case Section.THUMB:
+      case Section.LIST:
+        mostVisited.invalidate();
+        mostVisited.updateDisplayMode();
+        mostVisited.layout();
+        break;
+      case Section.RECENT:
+        renderRecentlyClosed();
+        break;
+      case Section.TIPS:
+        $('tip-line').style.display = '';
+        break;
+      case Section.SYNC:
+        $('sync-status').style.display = '';
+        break;
+    }
   }
 }
 
 function hideSection(section) {
   if (section & shownSections) {
     shownSections &= ~section;
 
-    if (section & Section.THUMB || section & Section.LIST) {
-      mostVisited.invalidate();
+    switch (section) {
+      case Section.THUMB:
+      case Section.LIST:
+        mostVisited.invalidate();
+        mostVisited.updateDisplayMode();
+        mostVisited.layout();
+        break;
+      case Section.RECENT:
+        renderRecentlyClosed();
+        break;
+      case Section.TIPS:
+        $('tip-line').style.display = 'none';
+        break;
+      case Section.SYNC:
+        $('sync-status').style.display = 'none';
+        break;
     }
-
-    if (section & Section.RECENT) {
-      renderRecentlyClosed();
-    }
-
-    mostVisited.updateDisplayMode();
-    mostVisited.layout();
   }
 }
 
 var mostVisited = {
   addPinnedUrl_: function(data, index) {
     chrome.send('addPinnedURL', [data.url, data.title, data.faviconUrl || '',
                                  data.thumbnailUrl || '', String(index)]);
   },
   getItem: function(el) {
     return findAncestorByClass(el, 'thumbnail-container');
@@ skipping 200 matching lines @@
   },
 
   getRectByIndex: function(index) {
     return getMostVisitedLayoutRects()[index];
   }
 };
 
 // Recently closed
 
 function layoutRecentlyClosed() {
-  var recentElement = $('recently-closed');
   var recentShown = shownSections & Section.RECENT;
-  var style = recentElement.style;
+  updateSimpleSection('recently-closed', Section.RECENT);
 
-  if (!recentShown) {
-    addClass(recentElement, 'collapsed');
-  } else {
-    removeClass(recentElement, 'collapsed');
-
+  if (recentShown) {
+    var recentElement = $('recently-closed');
+    var style = recentElement.style;
     // We cannot use clientWidth here since the width has a transition.
     var spacing = 20;
     var headerEl = recentElement.firstElementChild;
     var navEl = recentElement.lastElementChild;
     var navWidth = navEl.offsetWidth;
     // Subtract 10 for the padding
     var availWidth = (useSmallGrid() ? 690 : 918) - navWidth - 10;
 
     // Now go backwards and hide as many elements as needed.
     var elementsToHide = [];
@@ skipping 28 matching lines @@
  * linkurlisset: true if an URL should be set as the href for the link and false
  *               otherwise. If this field is false, then clicking on the link
  *               will result in sending a message to the backend (see
  *               'SyncLinkClicked').
  * linkurl: the URL to use as the element's href (only used if linkurlisset is
  *          true).
  */
 function syncMessageChanged(newMessage) {
   var syncStatusElement = $('sync-status');
   var style = syncStatusElement.style;
+  $('sync-menu-item').style.display = 'block';
 
   // Hide the section if the message is emtpy.
-  if (!newMessage.syncsectionisvisible) {
+  if (!newMessage['syncsectionisvisible'] || !(shownSections & Section.SYNC)) {
     style.display = 'none';
     return;
   }
   style.display = 'block';
 
   // Set the sync section background color based on the state.
   if (newMessage.msgtype == 'error') {
     style.backgroundColor = 'tomato';
   } else {
     style.backgroundColor = '';
@@ skipping 945 matching lines @@
 function fixLinkUnderline(el) {
   var span = document.createElement('span');
   span.className = 'link-color';
   while (el.hasChildNodes()) {
     span.appendChild(el.firstChild);
   }
   el.appendChild(span);
 }
 
 updateAttribution();