Sample chromite spec

Sample chromite spec

Change-Id: I049b31c2fc7369fa58ca43e24c2015e574231d7f

BUG=
TEST=none

[Vince Laviano, 2010-09-09 18:30:14]

http://codereview.chromium.org/3369009/diff/1/2
File chromite/specs/x86-generic.spec (right):

http://codereview.chromium.org/3369009/diff/1/2#newcode1
chromite/specs/x86-generic.spec:1: # chromite x86-generic target spec file
I think that this config file should be written as a Python dictionary
definition so that it can be imported and parsed by the Python interpreter
without extra effort on our part. Otherwise, we'll have to write code to parse
it and stick the key/value pairs in a dict.

Something like:

spec = {
  'overlay' : 'overlay-x86-generic',
  'profile' : 'x86-generic/dev',
  ...
}

http://codereview.chromium.org/3369009/diff/1/2#newcode18
chromite/specs/x86-generic.spec:18: #   "bleedingedge" is upto the minute
upstream portage
up to

http://codereview.chromium.org/3369009/diff/1/2#newcode58
chromite/specs/x86-generic.spec:58: # since each profile will require
partition/filesystem/hook information.
Yes, I still need to figure this out. This is fine as a placeholder. We can make
'partition' and 'partition_hooks' lists of strings, and 'filesystems' a list of
tuples of strings.

[anush, 2010-09-09 21:28:53]

PTAL

On 2010/09/09 18:30:14, Vince Laviano wrote:
> http://codereview.chromium.org/3369009/diff/1/2
> File chromite/specs/x86-generic.spec (right):
> 
> http://codereview.chromium.org/3369009/diff/1/2#newcode1
> chromite/specs/x86-generic.spec:1: # chromite x86-generic target spec file
> I think that this config file should be written as a Python dictionary
> definition so that it can be imported and parsed by the Python interpreter
> without extra effort on our part. Otherwise, we'll have to write code to parse
> it and stick the key/value pairs in a dict.
> 
> Something like:
> 
> spec = {
>   'overlay' : 'overlay-x86-generic',
>   'profile' : 'x86-generic/dev',
>   ...
> }
> 
> http://codereview.chromium.org/3369009/diff/1/2#newcode18
> chromite/specs/x86-generic.spec:18: #   "bleedingedge" is upto the minute
> upstream portage
> up to
> 
> http://codereview.chromium.org/3369009/diff/1/2#newcode58
> chromite/specs/x86-generic.spec:58: # since each profile will require
> partition/filesystem/hook information.
> Yes, I still need to figure this out. This is fine as a placeholder. We can
make
> 'partition' and 'partition_hooks' lists of strings, and 'filesystems' a list
of
> tuples of strings.

[Vince Laviano, 2010-09-09 22:32:51]

LGTM. 

For the record: anush and I talked offline, and we decided to use ConfigParser
instead of a raw dict so as not to evaluate arbitrary code that someone might
have placed in the spec file.