Fix semantic bugs in flashrom_util.py

Fix semantic bugs in flashrom_util.py

Change-Id: I41e3c919e7d084e17a9da6a9c32edffff6061d31

[Hung-Te, 2010-09-03 02:39:28]

Thanks for your fix!

LGTM except the fix to 'all' layout.

http://codereview.chromium.org/3367006/diff/1/2
File client/common_lib/flashrom_util.py (right):

http://codereview.chromium.org/3367006/diff/1/2#newcode717
client/common_lib/flashrom_util.py:717: layout_image)
This should be a None, because the special "all" is used to access "whole
flashrom" -- that means, we cannot trust the layout image.

[Tom Wai-Hong Tam, 2010-09-03 02:50:19]

Done. Change it in other way.

[Hung-Te, 2010-09-03 02:55:16]

http://codereview.chromium.org/3367006/diff/4001/5001
File client/common_lib/flashrom_util.py (right):

http://codereview.chromium.org/3367006/diff/4001/5001#newcode433
client/common_lib/flashrom_util.py:433: def detect_layout(self,
layout_desciption, size, image=None):
Please don't add this.

As previous discussion with Vadim, since the image will change its internal
behavior, we'd suggest not using default parameters so that everyone doing
layout will explicitly have their attention to whether they want to trust the
FMAP in image or not.

[Tom Wai-Hong Tam, 2010-09-03 04:42:46]

OK. Changed it back.

[Hung-Te, 2010-09-03 05:08:11]

LGTM.
Thanks again for the fix!