Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9441)

Unified Diff: chrome/test/functional/downloads.py

Issue 3367001: Work around download system breakpage by using WaitUntil on pyauto side. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/downloads.py
diff --git a/chrome/test/functional/downloads.py b/chrome/test/functional/downloads.py
index 5ec54844465c3364aba6e889f917ba518d94a03e..1af21c807db6a0a5ebd26acc8c84e21482e099e2 100644
--- a/chrome/test/functional/downloads.py
+++ b/chrome/test/functional/downloads.py
@@ -200,8 +200,12 @@ class DownloadsTest(pyauto.PyUITest):
self.DownloadAndWaitForStart(file_url)
# Waiting for big file to download might exceed automation timeout.
# Temporarily increase the automation timeout.
- self._CallFunctionWithNewTimeout(4 * 60 * 1000, # 4 min.
- self.WaitForAllDownloadsToComplete)
+
+ # Temp workaround for crbug.com/54131
+ # self._CallFunctionWithNewTimeout(4 * 60 * 1000, # 4 min.
+ # self.WaitForAllDownloadsToComplete)
+ self.WaitForAllDownloadsToComplete(timeout=4*60*1000)
+ # -- End workaround
# Verify that the file was correctly downloaded
self.assertTrue(os.path.exists(downloaded_pkg),
'Downloaded file %s missing.' % downloaded_pkg)
« no previous file with comments | « no previous file | chrome/test/pyautolib/pyauto.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698