Fix GetCachedFile....

Fix GetCachedFile.

BUG=none
TEST=gcl upload works when there's no codereview.settings in the cache.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58270

[Lei Zhang, 2010-09-01 23:18:29]

r57381 + r58201 = fail.

[Nicolas Sylvain, 2010-09-01 23:25:25]

LGTM

On Wed, Sep 1, 2010 at 4:18 PM, <thestig@chromium.org> wrote:

> Reviewers: Marc-Antoine Ruel, Nicolas Sylvain,
>
> Message:
> r57381 + r58201 = fail.
>
> Description:
> Fix GetCachedFile.
>
> BUG=none
> TEST=gcl upload works when there's no codereview.settings in the cache.
>
> Please review this at http://codereview.chromium.org/3366001/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/tools/depot_tools/
>
> Affected files:
>  M     gcl.py
>
>
> Index: gcl.py
> ===================================================================
> --- gcl.py      (revision 58259)
> +++ gcl.py      (working copy)
> @@ -143,7 +143,7 @@
>             # stderr into content_array.
>             content_array = []
>             svn_path = url_path + '/' + filename
> -            args = ['cat', svn_path]
> +            args = ['svn', 'cat', svn_path]
>             if sys.platform != 'darwin':
>               # MacOSX 10.5.2 has a bug with svn 1.4.4 that will trigger
> the
>               # 'Can\'t get username or password' and can be fixed easily.
>
>
>

[M-A Ruel, 2010-09-02 01:16:25]

oops, lgtm.