Issue 3364007: Turn visitor_id into a byte field and free back one word in Map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3364007: Turn visitor_id into a byte field and free back one word in Map. (Closed)

Created:
10 years, 3 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Visibility:
Public.

Turn visitor_id into a byte field and free back one word in Map. Committed: http://code.google.com/p/v8/source/detail?r=5414

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -9 lines)			Patch
M	src/objects.h	View	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+10 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Vyacheslav Egorov (Chromium)

10 years, 3 months ago (2010-09-03 13:39:37 UTC) #2

LGTM with static assertion on the range of VisitorId and if there is no serious
performance degradation.