Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 3363001: Different approach to NTP layout (Closed)

Created:
10 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org
Visibility:
Public.

Description

Instead of trying to arrange things so that there is something covering all the parts of the scrollable area we don't want to see, use -webkit-image-mask to only show the parts we do want to see. This change also fixes overflow of miniview items. Under some circumstances, the old JS approach wasn't working. Used a CSS one instead. TEST=Set up most visisted so that it has items. Start it in expanded mode. Minimize it. There should be no clipped last item. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58451

Patch Set 1 #

Total comments: 1

Patch Set 2 : different approach #

Patch Set 3 : yet another tak #

Patch Set 4 : cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -139 lines) Patch
M chrome/browser/resources/new_new_tab.css View 1 2 9 chunks +24 lines, -56 lines 0 comments Download
M chrome/browser/resources/new_new_tab.html View 2 4 chunks +19 lines, -25 lines 0 comments Download
M chrome/browser/resources/new_new_tab.js View 1 2 3 10 chunks +92 lines, -36 lines 2 comments Download
M chrome/browser/resources/new_tab_theme.css View 2 4 chunks +5 lines, -11 lines 0 comments Download
M chrome/browser/resources/ntp/apps.css View 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp/apps.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/ntp/most_visited.css View 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/ntp/most_visited.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Aaron Boodman
10 years, 3 months ago (2010-09-01 21:52:09 UTC) #1
arv (Not doing code reviews)
LGTM with nits http://codereview.chromium.org/3363001/diff/1/3 File chrome/browser/resources/new_new_tab.js (right): http://codereview.chromium.org/3363001/diff/1/3#newcode121 chrome/browser/resources/new_new_tab.js:121: parseInt(computedStyle.getPropertyValue("margin-top")) + Don't use parseInt without ...
10 years, 3 months ago (2010-09-01 23:48:33 UTC) #2
Aaron Boodman
I ended up doing this a different way. Please take a second look.
10 years, 3 months ago (2010-09-02 07:08:06 UTC) #3
arv (Not doing code reviews)
LGTM
10 years, 3 months ago (2010-09-02 15:56:15 UTC) #4
Aaron Boodman
I updated this cl to include the new layout approach we talked about yesterday. This ...
10 years, 3 months ago (2010-09-02 19:06:53 UTC) #5
arv (Not doing code reviews)
10 years, 3 months ago (2010-09-03 00:24:22 UTC) #6
LGTM

http://codereview.chromium.org/3363001/diff/3002/12003
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/3363001/diff/3002/12003#newcode240
chrome/browser/resources/new_new_tab.js:240: var gradientDestination =
"rgba(0,0,0," + (gradientHeightPx / 10) + ")";
s/"/'/

http://codereview.chromium.org/3363001/diff/3002/12003#newcode261
chrome/browser/resources/new_new_tab.js:261: console.log(gradient);
can you remove this log?

Powered by Google App Engine
This is Rietveld 408576698