Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 3362018: Kill factory partition dead. (Closed)

Created:
10 years, 3 months ago by Nick Sanders
Modified:
10 years, 3 months ago
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Don't allow booting of factory image after wipe. BUG=6655 TEST=manual run Change-Id: If774c7025005cb2f7c0cbe4209691aaf0aa6da7b

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : fix cgpt #

Total comments: 5

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Patch Set 8 : . #

Patch Set 9 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M client/site_tests/factory_Wipe/factory_Wipe.py View 2 chunks +4 lines, -3 lines 0 comments Download
M client/site_tests/factory_Wipe/src/switch_partitions.sh View 1 2 3 4 5 6 7 2 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 8 (0 generated)
Nick Sanders
10 years, 3 months ago (2010-09-11 05:39:18 UTC) #1
Nick Sanders
10 years, 3 months ago (2010-09-11 06:06:02 UTC) #2
Tom Wai-Hong Tam
http://codereview.chromium.org/3362018/diff/8001/9002 File client/site_tests/factory_Wipe/src/switch_partitions.sh (right): http://codereview.chromium.org/3362018/diff/8001/9002#newcode19 client/site_tests/factory_Wipe/src/switch_partitions.sh:19: ROOT_PART=$(echo "${ROOT_DEV}" | sed -e 's/^.*\([0-9]\)$/\1/') You can use ...
10 years, 3 months ago (2010-09-11 07:16:32 UTC) #3
Nick Sanders
http://codereview.chromium.org/3362018/diff/8001/9002 File client/site_tests/factory_Wipe/src/switch_partitions.sh (right): http://codereview.chromium.org/3362018/diff/8001/9002#newcode19 client/site_tests/factory_Wipe/src/switch_partitions.sh:19: ROOT_PART=$(echo "${ROOT_DEV}" | sed -e 's/^.*\([0-9]\)$/\1/') not with dash ...
10 years, 3 months ago (2010-09-11 07:24:05 UTC) #4
Tom Wai-Hong Tam
http://codereview.chromium.org/3362018/diff/8001/9002 File client/site_tests/factory_Wipe/src/switch_partitions.sh (right): http://codereview.chromium.org/3362018/diff/8001/9002#newcode19 client/site_tests/factory_Wipe/src/switch_partitions.sh:19: ROOT_PART=$(echo "${ROOT_DEV}" | sed -e 's/^.*\([0-9]\)$/\1/') :( How about ...
10 years, 3 months ago (2010-09-11 07:34:43 UTC) #5
Nick Sanders
I just copied the sed command from chromeos common. I'd prefer to use the standard ...
10 years, 3 months ago (2010-09-11 07:41:43 UTC) #6
Tom Wai-Hong Tam
OK. LGTM.
10 years, 3 months ago (2010-09-11 07:48:28 UTC) #7
hungte
10 years, 3 months ago (2010-09-13 02:37:32 UTC) #8
http://codereview.chromium.org/3362018/diff/23001/24002
File client/site_tests/factory_Wipe/src/switch_partitions.sh (right):

http://codereview.chromium.org/3362018/diff/23001/24002#newcode20
client/site_tests/factory_Wipe/src/switch_partitions.sh:20: ROOT_PART=$(echo
"${ROOT_DEV}" | sed -e 's/^.*\([0-9]\)$/\1/')
sed -e 's/.*[^0-9]//' would be simpler.

Powered by Google App Engine
This is Rietveld 408576698