Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 3361002: Update parallel_emerge to rebuild packages when use flags change. (Closed)

Created:
10 years, 3 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Update parallel_emerge to rebuild packages when use flags change. parallel_emerge now checks the use flags of installed packages against new packages, and checks the use flags of binary packages against source packages, so that, when the appropriate flags are used, we never install packages with the wrong use flags. I've also fix related bugs in rebuild_blacklist. Previously, rebuild_blacklist was too aggressive -- it even blacklisted packages from being rebuilt if they are explicit workon packages. This bug also causes problems for the use flag detection code because packages in this list would not get rebuilt when the use flags changed. So I fixed this too. Also relatedly, I've fixed our code for checking whether --selective is enabled to look at the --newuse and --reinstall=changed-use flags. These flags actually enable --selective implicitly, so we need to honor that for correct behavior. BUG=chromium-os:6359 TEST=Made sure that packages get rebuilt / reinstalled when use flags change. Change-Id: I2d945b552863410ec7b286c3ed55ae4a64336ed5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -13 lines) Patch
M parallel_emerge View 10 chunks +77 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years, 3 months ago (2010-09-01 23:22:01 UTC) #1
Nick Sanders
10 years, 3 months ago (2010-09-02 06:13:29 UTC) #2
lgtm, nice comments! I more or less got what it was doing first pass!

Powered by Google App Engine
This is Rietveld 408576698