Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1653)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/socket_stream/socket_stream.cc

Issue 3360017: Fix multi-round authentication.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: SocketStream fix Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/mock_sspi_library_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/socket_stream/socket_stream.cc
===================================================================
--- net/socket_stream/socket_stream.cc (revision 59119)
+++ net/socket_stream/socket_stream.cc (working copy)
@@ -930,10 +930,11 @@
LOG(INFO) << "The proxy " << auth_origin << " requested auth";
- // The auth we tried just failed, hence it can't be valid.
- // Remove it from the cache so it won't be used again.
- if (auth_handler_.get() && !auth_identity_.invalid &&
- auth_handler_->IsFinalRound()) {
+ // TODO(cbentzel): Since SocketStream only suppports basic authentication
+ // right now, another challenge is always treated as a rejection.
+ // Ultimately this should be converted to use HttpAuthController like the
+ // HttpNetworkTransaction has.
+ if (auth_handler_.get() && !auth_identity_.invalid) {
if (auth_identity_.source != HttpAuth::IDENT_SRC_PATH_LOOKUP)
auth_cache_.Remove(auth_origin,
auth_handler_->realm(),
« no previous file with comments | « net/http/mock_sspi_library_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698