10 years, 3 months ago
(2010-09-08 16:50:02 UTC)
#1
Sam Leffler
LGTM
10 years, 3 months ago
(2010-09-09 18:11:37 UTC)
#2
LGTM
Nathan Williams
This change LGTM, but it's not the only problem we have with the script in ...
10 years, 3 months ago
(2010-09-09 18:42:25 UTC)
#3
This change LGTM, but it's not the only problem we have with the script in our
lab setup, so the bug should stay open.
adlr
How hard would it be for you to debug the script? When doing a full ...
10 years, 3 months ago
(2010-09-10 00:40:23 UTC)
#4
How hard would it be for you to debug the script? When doing a full update,
it's not that much of a wrapper around mk_memento_images.sh
-andrew
On Thu, Sep 9, 2010 at 11:42 AM, <njw@chromium.org> wrote:
> This change LGTM, but it's not the only problem we have with the script in
> our
> lab setup, so the bug should stay open.
>
>
> http://codereview.chromium.org/3359014/show
>
Paul Stewart
Actually, this is the only change we needed. If you push this, we'll be all ...
10 years, 3 months ago
(2010-09-16 02:12:56 UTC)
#5
Actually, this is the only change we needed. If you push this, we'll be all
set, for now.
--
Paul
On 2010/09/10 00:40:23, adlr wrote:
> How hard would it be for you to debug the script? When doing a full update,
> it's not that much of a wrapper around mk_memento_images.sh
>
> -andrew
>
> On Thu, Sep 9, 2010 at 11:42 AM, <mailto:njw@chromium.org> wrote:
>
> > This change LGTM, but it's not the only problem we have with the script in
> > our
> > lab setup, so the bug should stay open.
> >
> >
> > http://codereview.chromium.org/3359014/show
> >
>
adlr
pushed. sorry for the delay On Wed, Sep 15, 2010 at 7:12 PM, <pstew@chromium.org> wrote: ...
10 years, 3 months ago
(2010-09-16 02:20:07 UTC)
#6
pushed. sorry for the delay
On Wed, Sep 15, 2010 at 7:12 PM, <pstew@chromium.org> wrote:
> Actually, this is the only change we needed. If you push this, we'll be
> all
> set, for now.
>
> --
> Paul
>
> On 2010/09/10 00:40:23, adlr wrote:
>
>> How hard would it be for you to debug the script? When doing a full
>> update,
>> it's not that much of a wrapper around mk_memento_images.sh
>>
>
> -andrew
>>
>
> On Thu, Sep 9, 2010 at 11:42 AM, <mailto:njw@chromium.org> wrote:
>>
>
> > This change LGTM, but it's not the only problem we have with the script
>> in
>> > our
>> > lab setup, so the bug should stay open.
>> >
>> >
>> > http://codereview.chromium.org/3359014/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/3359014/show
>
Issue 3359014: AU: when generating payload, only delta generation needs to be in chroot
(Closed)
Created 10 years, 3 months ago by adlr
Modified 9 years ago
Reviewers: Nathan Williams, Sam Leffler, Paul Stewart
Base URL: ssh://git@chromiumos-git/crosutils.git
Comments: 0