Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 3359014: AU: when generating payload, only delta generation needs to be in chroot (Closed)

Created:
10 years, 3 months ago by adlr
Modified:
9 years ago
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://git@chromiumos-git/crosutils.git
Visibility:
Public.

Description

AU: when generating payload, only delta generation needs to be in chroot BUG=chromium-os:6517 TEST=generated full payload outside chroot

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M cros_generate_update_payload View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
adlr
10 years, 3 months ago (2010-09-08 16:50:02 UTC) #1
Sam Leffler
LGTM
10 years, 3 months ago (2010-09-09 18:11:37 UTC) #2
Nathan Williams
This change LGTM, but it's not the only problem we have with the script in ...
10 years, 3 months ago (2010-09-09 18:42:25 UTC) #3
adlr
How hard would it be for you to debug the script? When doing a full ...
10 years, 3 months ago (2010-09-10 00:40:23 UTC) #4
Paul Stewart
Actually, this is the only change we needed. If you push this, we'll be all ...
10 years, 3 months ago (2010-09-16 02:12:56 UTC) #5
adlr
10 years, 3 months ago (2010-09-16 02:20:07 UTC) #6
pushed. sorry for the delay

On Wed, Sep 15, 2010 at 7:12 PM, <pstew@chromium.org> wrote:

> Actually, this is the only change we needed.  If you push this, we'll be
> all
> set, for now.
>
> --
> Paul
>
> On 2010/09/10 00:40:23, adlr wrote:
>
>> How hard would it be for you to debug the script? When doing a full
>> update,
>> it's not that much of a wrapper around mk_memento_images.sh
>>
>
>  -andrew
>>
>
>  On Thu, Sep 9, 2010 at 11:42 AM, <mailto:njw@chromium.org> wrote:
>>
>
>  > This change LGTM, but it's not the only problem we have with the script
>> in
>> > our
>> > lab setup, so the bug should stay open.
>> >
>> >
>> > http://codereview.chromium.org/3359014/show
>> >
>>
>
>
>
>
> http://codereview.chromium.org/3359014/show
>

Powered by Google App Engine
This is Rietveld 408576698