Issue 3358028: Revert r59012 which started using Chrome sockets for sync.

Issue 3358028: Revert r59012 which started using Chrome sockets for sync. (Closed)

Created:
10 years, 3 months ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
akalin

CC:
chromium-reviews, ncarter (slow), Alpha Left Google, ben+cc_chromium.org, Sergey Ulanov, Raghu Simha, idana, dmac, pam+watch_chromium.org, awong, garykac, tim (not reviewing), eroman

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Revert r59012 which started using Chrome sockets for sync. This caused us to write to ChromeNetLog from the sync thread. ChromeNetLog is not thread safe, so this causes problems. BUG=55116, 54146 TEST=Start up chrome. Does not repeatedly hit DCHECKs on ChromeNetLog::AddEntry(). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59104

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+533 lines, -73 lines)			Patch
M	chrome/browser/sync/profile_sync_service.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/tools/sync_listen_notifications.cc	View	8 chunks	+36 lines, -7 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	jingle/jingle.gyp	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	jingle/notifier/base/notifier_options.h	View	1 chunk	+10 lines, -3 lines	0 comments	Download
A	jingle/notifier/base/signal_thread_task.h	View	1 chunk	+96 lines, -0 lines	0 comments	Download
A +	jingle/notifier/base/ssl_adapter.h	View	2 chunks	+6 lines, -6 lines	0 comments	Download
A +	jingle/notifier/base/ssl_adapter.cc	View	1 chunk	+5 lines, -5 lines	0 comments	Download
A	jingle/notifier/base/static_assert.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
M	jingle/notifier/communicator/login.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	jingle/notifier/communicator/login.cc	View	4 chunks	+6 lines, -1 line	0 comments	Download
A	jingle/notifier/communicator/product_info.h	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	jingle/notifier/communicator/product_info.cc	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	jingle/notifier/communicator/single_login_attempt.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	jingle/notifier/communicator/single_login_attempt.cc	View	7 chunks	+209 lines, -21 lines	0 comments	Download
A +	jingle/notifier/communicator/ssl_socket_adapter.h	View	4 chunks	+6 lines, -6 lines	0 comments	Download
A +	jingle/notifier/communicator/ssl_socket_adapter.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	jingle/notifier/communicator/xmpp_connection_generator.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A +	jingle/notifier/communicator/xmpp_socket_adapter.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
A +	jingle/notifier/communicator/xmpp_socket_adapter.cc	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	jingle/notifier/listener/mediator_thread_impl.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	jingle/notifier/listener/mediator_thread_impl.cc	View	4 chunks	+46 lines, -0 lines	0 comments	Download
M	remoting/DEPS	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/jingle_glue/jingle_client.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

TBR

Expand Messages | Collapse Messages