Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 3358015: Split _Run() in two to make redirection simpler in a later change. (Closed)

Created:
10 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Split _Run() in two to make redirection simpler in a later change. Simplify GitWrapper._Run() and move logging at the right place. TEST=none BUG=54084 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58694

Patch Set 1 #

Patch Set 2 : remove dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -41 lines) Patch
M gclient_scm.py View 1 13 chunks +30 lines, -41 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
10 years, 3 months ago (2010-09-03 19:14:32 UTC) #1
bradn
10 years, 3 months ago (2010-09-03 20:31:57 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698