Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3358014: Cleanup some duplicated includes. (Closed)

Created:
10 years, 3 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
tony, Elliot Glaysher
CC:
chromium-reviews, ben+cc_chromium.org, pam+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Cleanup some duplicated includes. BUG=None TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58582

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M base/debug_util_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M base/linux_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
A tiny cleanup, but not sure if it is worth though.
10 years, 3 months ago (2010-09-03 19:00:34 UTC) #1
tony
LGTM. How did you find these? Is there a script we can check-in that will ...
10 years, 3 months ago (2010-09-03 19:07:49 UTC) #2
tfarina
On 2010/09/03 19:07:49, tony wrote: > LGTM. How did you find these? I've used this ...
10 years, 3 months ago (2010-09-03 19:12:05 UTC) #3
tony
Actually, I'm surprised cpplint doesn't already do this. Or maybe it does and these got ...
10 years, 3 months ago (2010-09-03 19:22:38 UTC) #4
Elliot Glaysher
10 years, 3 months ago (2010-09-03 19:45:18 UTC) #5 
On Fri, Sep 3, 2010 at 12:22 PM,  <tony@chromium.org> wrote:
> Actually, I'm surprised cpplint doesn't already do this.  Or maybe it does
> and
> these got added before cpplint became a presubmit hook.  Maybe erg knows.

It may or may not. I disable most of the header tests because our pattern of:

#ifndef defined(OS_BLAH)
#include "blah_os.h"
#endif

confuses the heck out of cpplint's header stuff, and is so widespread
I just disabled that category of tests.

-- Elliot

Powered by Google App Engine
This is Rietveld 408576698