Issue 3358006: Revert 58328 - Pull new PPAPI, reland 58319 and 58321....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3358006: Revert 58328 - Pull new PPAPI, reland 58319 and 58321.... (Closed)

Created:
10 years, 3 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, jam, dmac, darin-cc_chromium.org, awong, garykac, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 58328 - Pull new PPAPI, reland 58319 and 58321. TEST=unit test included BUG=none TBR=brettw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58354

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -132 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/ui/ppapi_uitest.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	remoting/client/plugin/pepper_entrypoints.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_instance.cc	View	4 chunks	+0 lines, -50 lines	0 comments	Download
M	webkit/glue/plugins/pepper_var.h	View	2 chunks	+0 lines, -28 lines	0 comments	Download
M	webkit/glue/plugins/pepper_var.cc	View	4 chunks	+56 lines, -47 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rohitrao (ping after 24h)

10 years, 3 months ago (2010-09-02 15:09:11 UTC) #2

This was consistently failing PPAPITest.Instance on the linux
dbg-shlib bot.  Logs are at
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20Buil...
.

On Thu, Sep 2, 2010 at 11:07 AM,  <rohitrao@chromium.org> wrote:
> Reviewers: brettw,
>
> Description:
> Revert 58328 - Pull new PPAPI, reland 58319 and 58321.
>
> TEST=unit test included
> BUG=none
>
> TBR=brettw@chromium.org
>
> Please review this at http://codereview.chromium.org/3358006/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>  M     chrome/test/ui/ppapi_uitest.cc
>  M     remoting/client/plugin/pepper_entrypoints.cc
>  M     webkit/glue/plugins/pepper_plugin_instance.h
>  M     webkit/glue/plugins/pepper_plugin_instance.cc
>  M     webkit/glue/plugins/pepper_var.h
>  M     webkit/glue/plugins/pepper_var.cc
>
>
>

Expand Messages | Collapse Messages