Issue 3357010: Fix Unexpected crash_sender stdout/stderr when testing Official image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3357010: Fix Unexpected crash_sender stdout/stderr when testing Official image (Closed)

Created:
10 years, 3 months ago by hughd

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/crash-reporter.git

Visibility:
Public.

Description

Fix Unexpected crash_sender stdout/stderr when testing Official image logging_KernelCrashServer and logging_UserCrash tests fail on an Official image, because crash_sender's is_official() test leaks the "Official" line: grep needs the quiet option (and does not need a cut). BUG=837 TEST=logging_UserCrash Signed-off-by: Hugh Dickins <hughd@chromium.org>;

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	crash_sender	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages