Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: views/controls/table/group_table_view.cc

Issue 3354005: Re-lands 58186: (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/table/group_table_view.h ('k') | views/controls/table/native_table_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/controls/table/group_table_view.cc
diff --git a/views/controls/table/group_table_view.cc b/views/controls/table/group_table_view.cc
index 14a5eae680ea2b6e56c9952312b4e6055a509953..efef1a52eb4d8901742a73f426dd73892eddacff 100644
--- a/views/controls/table/group_table_view.cc
+++ b/views/controls/table/group_table_view.cc
@@ -61,7 +61,7 @@ void GroupTableView::SyncSelection() {
}
}
-bool GroupTableView::OnKeyDown(base::KeyboardCode virtual_keycode) {
+bool GroupTableView::OnKeyDown(app::KeyboardCode virtual_keycode) {
// In a list view, multiple items can be selected but only one item has the
// focus. This creates a problem when the arrow keys are used for navigating
// between items in the list view. An example will make this more clear:
@@ -87,8 +87,8 @@ bool GroupTableView::OnKeyDown(base::KeyboardCode virtual_keycode) {
// detect that one of the arrow keys is pressed. Thus, when it comes time
// for the list view control to actually switch the focus, the right item
// will be selected.
- if ((virtual_keycode != base::VKEY_UP) &&
- (virtual_keycode != base::VKEY_DOWN)) {
+ if ((virtual_keycode != app::VKEY_UP) &&
+ (virtual_keycode != app::VKEY_DOWN)) {
return TableView::OnKeyDown(virtual_keycode);
}
@@ -116,10 +116,10 @@ bool GroupTableView::OnKeyDown(base::KeyboardCode virtual_keycode) {
// If the user pressed the UP key, then the focus should be set to the
// topmost element in the group. If the user pressed the DOWN key, the focus
// should be set to the bottommost element.
- if (virtual_keycode == base::VKEY_UP) {
+ if (virtual_keycode == app::VKEY_UP) {
SetFocusOnItem(group_range.start);
} else {
- DCHECK_EQ(virtual_keycode, base::VKEY_DOWN);
+ DCHECK_EQ(virtual_keycode, app::VKEY_DOWN);
SetFocusOnItem(group_range.start + group_range.length - 1);
}
« no previous file with comments | « views/controls/table/group_table_view.h ('k') | views/controls/table/native_table_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698