Issue 3353018: Make gclient_scm_test much more silent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3353018: Make gclient_scm_test much more silent (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Simplify GIT.Capture() code to always redirect stderr by default and always throw an exception on failure. Make gclient_scm_test silent. Replace raise Exception() with raise gclient_utils.Error(). BUG=54084 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58936

Patch Set 1 #

Patch Set 2 : cleaner #

Patch Set 3 : gclient_scm_test can now be run #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -91 lines)			Patch
M	PRESUBMIT.py	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	gclient_scm.py	View	1	12 chunks	+20 lines, -36 lines	0 comments	Download
M	gclient_utils.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	scm.py	View	1	9 chunks	+36 lines, -45 lines	0 comments	Download
M	tests/gclient_scm_test.py	View		5 chunks	+16 lines, -5 lines	0 comments	Download
M	tests/scm_unittest.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages