Issue 3353006: Fix cookies test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3353006: Fix cookies test (Closed)

Created:
10 years, 3 months ago by Nirnimesh

Modified:
9 years, 7 months ago

Reviewers:
Alyssa

CC:
chromium-reviews, Paweł Hajdan Jr.

Visibility:
Public.

Description

Fix cookies test The cookies test used to sometimes fail because it would load google.com twice and try to match cookies, but google.com can set slightly different cookies. While attempting to fix that I relaxed the test and refactored to make it more straightforward. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58298

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -23 lines)			Patch
	M	chrome/test/functional/cookies.py	View	1	2 chunks	+23 lines, -23 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Alyssa

10 years, 3 months ago (2010-09-02 00:33:07 UTC) #2

LGTM

http://codereview.chromium.org/3353006/diff/2001/3001
File chrome/test/functional/cookies.py (right):

http://codereview.chromium.org/3353006/diff/2001/3001#newcode34
chrome/test/functional/cookies.py:34: self._CookieCheckIncognitoWindow(http_url)
nit: Maybe comment above this call # Incognito window (here and in other tests).
Just to break up the test into obvious sections. Not necessary - entirely your
call.

Expand Messages | Collapse Messages