Issue 3353003: Fixed crash involving using NetAddress::Adopt() incorrectly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3353003: Fixed crash involving using NetAddress::Adopt() incorrectly (Closed)

Created:
10 years, 3 months ago by akalin

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Visibility:
Public.

Description

Fixed crash involving using NetAddress::Adopt() incorrectly Replaced use of NetAddress::Adopt() in ChromeAsyncSocket with the single-IP constructor. Clarified comment for NetAddress::Adopt(). BUG=54108 TEST=Windows sync integration tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58273

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -20 lines)			Patch
	M	jingle/notifier/base/chrome_async_socket.cc	View		2 chunks	+13 lines, -17 lines	0 comments	Download
	M	net/base/address_list.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages