chrome/browser/speech/speech_recognizer.cc - Issue 3352018: Show error messages in speech bubble allowing user to retry as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/speech/speech_recognizer.cc

Issue 3352018: Show error messages in speech bubble allowing user to retry as well. (Closed)

Patch Set: Address joth's comments. Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/speech/speech_recognizer.cc

diff --git a/chrome/browser/speech/speech_recognizer.cc b/chrome/browser/speech/speech_recognizer.cc

index b6c4c7dd09a47a8fa318e39c1016f5a6105c4feb..800b0445804eaf4d63be9b92dae39370c31a9aed 100644

--- a/chrome/browser/speech/speech_recognizer.cc

+++ b/chrome/browser/speech/speech_recognizer.cc

@@ -307,8 +307,6 @@ void SpeechRecognizer::InformErrorAndCancelRecognition(ErrorCode error) {

// Guard against the delegate freeing us until we finish our job.

scoped_refptr<SpeechRecognizer> me(this);

delegate_->OnRecognizerError(caller_id_, error);

- delegate_->DidCompleteRecording(caller_id_);

- delegate_->DidCompleteRecognition(caller_id_);

}

} // namespace speech_input