Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: chrome/browser/speech/speech_input_bubble_mac.mm

Issue 3352018: Show error messages in speech bubble allowing user to retry as well. (Closed)
Patch Set: Address joth's comments. Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/speech_input_bubble_mac.mm
diff --git a/chrome/browser/speech/speech_input_bubble_mac.mm b/chrome/browser/speech/speech_input_bubble_mac.mm
index 43a390a1a05e30c443664a6cfae9ab25ad5b118e..fd01ca29c4057cb7722c2f0848cefabecf45ec52 100644
--- a/chrome/browser/speech/speech_input_bubble_mac.mm
+++ b/chrome/browser/speech/speech_input_bubble_mac.mm
@@ -16,13 +16,15 @@ namespace {
// A class to bridge between the speech recognition C++ code and the Objective-C
// bubble implementation. See chrome/browser/speech/speech_input_bubble.h for
// more information on how this gets used.
-class SpeechInputBubbleImpl : public SpeechInputBubble {
+class SpeechInputBubbleImpl : public SpeechInputBubbleBase {
public:
SpeechInputBubbleImpl(TabContents* tab_contents,
Delegate* delegate,
const gfx::Rect& element_rect);
virtual ~SpeechInputBubbleImpl();
- virtual void SetRecognizingMode();
+ virtual void Show();
+ virtual void Hide();
+ virtual void UpdateLayout();
private:
scoped_nsobject<SpeechInputWindowController> window_;
@@ -53,8 +55,19 @@ SpeechInputBubbleImpl::~SpeechInputBubbleImpl() {
[window_.get() close];
}
-void SpeechInputBubbleImpl::SetRecognizingMode() {
- [window_.get() didStartRecognition];
+void SpeechInputBubbleImpl::Show() {
+ // TODO(satish): Implement.
+ NOTREACHED();
+}
+
+void SpeechInputBubbleImpl::Hide() {
+ // TODO(satish): Implement.
+ NOTREACHED();
+}
+
+void SpeechInputBubbleImpl::UpdateLayout() {
+ // TODO(satish): Implement.
+ NOTREACHED();
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698