Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3352010: Fix ibus autotest by having it launch ibus-daemon itself. (Closed)

Created:
10 years, 3 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano, ericli, petkov+cc_chromium.org
Base URL:
ssh://gitrw.chromium.org/autotest.git
Visibility:
Public.

Description

Fix ibus autotest by having it launch ibus-daemon itself. BUG=chromium-os:5617 TEST=Run the autotest

Patch Set 1 #

Patch Set 2 : Code Review #

Total comments: 6

Patch Set 3 : Code review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -16 lines) Patch
M client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py View 1 2 6 chunks +63 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zachary Kuznia
10 years, 3 months ago (2010-09-08 09:05:10 UTC) #1
satorux1
Sorry for the belated response. Forgot to hit "submit" button.. http://codereview.chromium.org/3352010/diff/2001/3001 File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right): http://codereview.chromium.org/3352010/diff/2001/3001#newcode15 ...
10 years, 3 months ago (2010-09-09 00:51:55 UTC) #2
Zachary Kuznia
http://codereview.chromium.org/3352010/diff/2001/3001 File client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py (right): http://codereview.chromium.org/3352010/diff/2001/3001#newcode15 client/site_tests/desktopui_IBusTest/desktopui_IBusTest.py:15: self._cand_job = None On 2010/09/09 00:51:55, satorux1 wrote: > ...
10 years, 3 months ago (2010-09-09 05:25:31 UTC) #3
satorux1
10 years, 3 months ago (2010-09-09 06:41:41 UTC) #4 
LGTM. Thank you for fixing this!

Powered by Google App Engine
This is Rietveld 408576698