Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 3351016: Install make.globals and create make.profile directory (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

Install make.globals and create make.profile directory Some mod_for_test images don't have the files necessary to run emerge. Install them. BUG=none TEST=Rerun package install

Patch Set 1 #

Patch Set 2 : Move change to build_image so we can share with gmerge #

Total comments: 2

Patch Set 3 : Add braces as per David #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build_image View 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-08 23:15:09 UTC) #1
Sam Leffler
would it be better to fix mod_image_for_test instead? I can't tell if this fixes the ...
10 years, 3 months ago (2010-09-08 23:33:47 UTC) #2
sosa
I actually noticed this when moving to the statefuldev logic. The issue is gmerge creates ...
10 years, 3 months ago (2010-09-08 23:38:33 UTC) #3
Paul Stewart
PTAL, folks. I've tested that the files are correctly created at the end of build_image ...
10 years, 3 months ago (2010-09-09 02:40:37 UTC) #4
Sam Leffler
I thought make.globals needed to be installed in /etc/make.profile/make.globals? This doesn't appear to do that. ...
10 years, 3 months ago (2010-09-09 03:28:18 UTC) #5
sosa
Nit, o/w LGTM after testing Sam's suggestion. I think you are correct with make.globals in ...
10 years, 3 months ago (2010-09-09 04:50:05 UTC) #6
Paul Stewart
10 years, 3 months ago (2010-09-09 12:40:52 UTC) #7
http://codereview.chromium.org/3351016/diff/5001/6001
File build_image (right):

http://codereview.chromium.org/3351016/diff/5001/6001#newcode399
build_image:399: sudo cp $root_dev_dir/etc/make.globals ${ROOT_FS_DIR}/etc/
On 2010/09/09 04:50:05, sosa wrote:
> ${root_dev_dir}

Done.

Powered by Google App Engine
This is Rietveld 408576698