Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 335032: Add a check for NULL in PopulateFolderCombo. (Closed)

Created:
11 years, 1 month ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Add a check for NULL in PopulateFolderCombo. BUG=25849 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30108

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/gtk/bookmark_bubble_gtk.cc View 1 2 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
11 years, 1 month ago (2009-10-26 20:50:56 UTC) #1
Evan Stade
http://codereview.chromium.org/335032/diff/1/2 File chrome/browser/gtk/bookmark_bubble_gtk.cc (right): http://codereview.chromium.org/335032/diff/1/2#newcode42 Line 42: return nodes; why return early? I think you ...
11 years, 1 month ago (2009-10-26 20:59:17 UTC) #2
Lei Zhang
On 2009/10/26 20:59:17, Evan Stade wrote: > http://codereview.chromium.org/335032/diff/1/2 > File chrome/browser/gtk/bookmark_bubble_gtk.cc (right): > > http://codereview.chromium.org/335032/diff/1/2#newcode42 ...
11 years, 1 month ago (2009-10-26 21:14:55 UTC) #3
Evan Stade
11 years, 1 month ago (2009-10-26 21:37:12 UTC) #4
lgtm with nits

http://codereview.chromium.org/335032/diff/2002/1002
File chrome/browser/gtk/bookmark_bubble_gtk.cc (right):

http://codereview.chromium.org/335032/diff/2002/1002#newcode42
Line 42: const BookmarkNode* parent = NULL;
nit: const BookmarkNode* parent = node ? node->GetParent() : NULL;

http://codereview.chromium.org/335032/diff/2002/1002#newcode80
Line 80: int parent_index = 0;
nit: s/int/gint (as long as you're here)

Powered by Google App Engine
This is Rietveld 408576698