Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 335031: Update Mac fonts (Closed)

Created:
11 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update fonts on Mac: - Get rid of Arial as default - Update non-English font choices (based mostly on Mozilla's choices, <http://mxr.mozilla.org/seamonkey/source/modules/libpref/src/init/all.js>; cross-referenced with what's installed with the OS) BUG=http://crbug.com/19135; http://crbug.com/20171 TEST=as in bugs

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 5

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Total comments: 9

Patch Set 5 : '' #

Patch Set 6 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1020 lines, -306 lines) Patch
M chrome/app/resources/locale_settings_am.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ar.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_bg.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_bn.xtb View 1 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ca.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_cs.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_da.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_de.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_el.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_en-GB.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_es.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_es-419.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_et.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_fi.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_fil.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_fr.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_gu.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_he.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_hi.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_hr.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_hu.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_id.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_it.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ja.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_kn.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ko.xtb View 2 3 4 5 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_lt.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_lv.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ml.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_mr.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_nb.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_nl.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_or.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_pl.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-BR.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_pt-PT.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ro.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ru.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_sk.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_sl.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_sr.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_sv.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_sw.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_ta.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_te.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_th.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_tr.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_uk.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_vi.xtb View 2 3 4 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-CN.xtb View 2 3 4 5 1 chunk +20 lines, -6 lines 0 comments Download
M chrome/app/resources/locale_settings_zh-TW.xtb View 2 3 4 5 1 chunk +20 lines, -6 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Avi (use Gerrit)
11 years, 1 month ago (2009-10-26 20:31:57 UTC) #1
Avi (use Gerrit)
Scope of CL widened. Please review.
11 years, 1 month ago (2009-10-27 19:10:39 UTC) #2
jungshik at Google
For Indic languages and Hebrew, I think just using the common set (Courier, Times, Helvetica) ...
11 years, 1 month ago (2009-10-27 22:07:33 UTC) #3
Avi (use Gerrit)
In general, I'm OK with just letting font fallback happen, so for the Indics I'll ...
11 years, 1 month ago (2009-10-28 15:41:12 UTC) #4
jungshik at Google
On 2009/10/28 15:41:12, Avi wrote: > In general, I'm OK with just letting font fallback ...
11 years, 1 month ago (2009-10-28 17:56:15 UTC) #5
jungshik at Google
http://codereview.chromium.org/335031/diff/3004/3020 File chrome/app/resources/locale_settings_ru.xtb (right): http://codereview.chromium.org/335031/diff/3004/3020#newcode22 Line 22: <translation id="IDS_FIXED_FONT_FAMILY">Monaco CY</translation> Oh no. Please, don't use ...
11 years, 1 month ago (2009-10-28 17:57:56 UTC) #6
jungshik at Google
On 2009/10/28 17:57:56, Jungshik Shin wrote: > http://codereview.chromium.org/335031/diff/3004/3020 > File chrome/app/resources/locale_settings_ru.xtb (right): > > http://codereview.chromium.org/335031/diff/3004/3020#newcode22 ...
11 years, 1 month ago (2009-10-28 18:07:55 UTC) #7
Avi (use Gerrit)
On 2009/10/28 18:07:55, Jungshik Shin wrote: > I'm tempted to use TNR/Arial/Courier New for > ...
11 years, 1 month ago (2009-10-28 18:22:48 UTC) #8
Avi (use Gerrit)
OTOH, for CJK, I think we should use the dedicated fonts there rather than fallback ...
11 years, 1 month ago (2009-10-28 18:27:54 UTC) #9
jungshik at Google
On 2009/10/28 18:27:54, Avi wrote: > OTOH, for CJK, I think we should use the ...
11 years, 1 month ago (2009-10-29 21:15:26 UTC) #10
jungshik at Google
http://codereview.chromium.org/335031/diff/10001/9011 File chrome/app/resources/locale_settings_ja.xtb (right): http://codereview.chromium.org/335031/diff/10001/9011#newcode8 Line 8: <translation id="IDS_WEB_FONT_FAMILY">Helvetica</translation> "Helvetica, Hiragino Kaku Gothic Pro" might ...
11 years, 1 month ago (2009-10-29 21:57:37 UTC) #11
Avi (use Gerrit)
http://codereview.chromium.org/335031/diff/10001/9011 File chrome/app/resources/locale_settings_ja.xtb (right): http://codereview.chromium.org/335031/diff/10001/9011#newcode8 Line 8: <translation id="IDS_WEB_FONT_FAMILY">Helvetica</translation> On 2009/10/29 21:57:37, Jungshik Shin wrote: ...
11 years, 1 month ago (2009-10-30 15:58:28 UTC) #12
Mark Mentovai
jshin@chromium.org wrote: > http://codereview.chromium.org/335031/diff/10001/9011#newcode8 > Line 8: <translation id="IDS_WEB_FONT_FAMILY">Helvetica</translation> > "Helvetica, Hiragino Kaku Gothic Pro" ...
11 years, 1 month ago (2009-10-30 16:04:31 UTC) #13
jungshik at Google
On 2009/10/30 16:04:31, Mark Mentovai wrote: > mailto:jshin@chromium.org wrote: > > http://codereview.chromium.org/335031/diff/10001/9011#newcode8 > > Line ...
11 years, 1 month ago (2009-10-30 16:33:09 UTC) #14
Avi (use Gerrit)
On 2009/10/30 16:33:09, Jungshik Shin wrote: > The point is to make > Japanese domUI ...
11 years, 1 month ago (2009-10-30 16:35:30 UTC) #15
jungshik at Google
On 2009/10/30 16:35:30, Avi wrote: > On 2009/10/30 16:33:09, Jungshik Shin wrote: > > The ...
11 years, 1 month ago (2009-10-30 16:54:24 UTC) #16
jungshik at Google
I meant 'Courier' (not 'Courier New').
11 years, 1 month ago (2009-10-30 16:55:52 UTC) #17
Avi (use Gerrit)
Does monospace mean much for CJK (re columns lining up)? Let's do Courier and let ...
11 years, 1 month ago (2009-10-30 17:21:57 UTC) #18
Avi (use Gerrit)
Changes from last time: - Korean has no cursive (uses Apple Chancery) - Korean and ...
11 years, 1 month ago (2009-10-30 17:25:01 UTC) #19
jungshik at Google
LGTM ! On 2009/10/30 17:25:01, Avi wrote: > Changes from last time: > > - ...
11 years, 1 month ago (2009-10-30 21:58:53 UTC) #20
jungshik at Google
On 2009/10/30 17:21:57, Avi wrote: > Does monospace mean much for CJK (re columns lining ...
11 years, 1 month ago (2009-10-30 22:01:59 UTC) #21
Avi (use Gerrit)
11 years, 1 month ago (2009-11-02 15:48:41 UTC) #22
On 2009/10/30 22:01:59, Jungshik Shin wrote:
> Yes, that's better although the width ratio between the "ASCII portion" and
the
> CJK is not 1:2 (as expected by East Asian users).

:( This'll have to do for now; if they need that they can tweak the font.

Powered by Google App Engine
This is Rietveld 408576698