tools/valgrind/valgrind.sh - Issue 335026: Set GTEST_DEATH_TEST_USE_FORK environment variable to make death tests valgri...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/valgrind/valgrind.sh

Issue 335026: Set GTEST_DEATH_TEST_USE_FORK environment variable to make death tests valgri... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/valgrind/valgrind.sh

===================================================================

--- tools/valgrind/valgrind.sh (revision 30042)

+++ tools/valgrind/valgrind.sh (working copy)

@@ -97,9 +97,7 @@

# If it crashes on you in the Options menu, you hit bug 19751,

# comment out the G_DEBUG=fatal_warnings line.

-# --smc-check=all: handle v8's dynamic code generation.

-# (though we can probably remove that now that v8 is annotated).

-# --trace-children to follow into the renderer processes.

+# GTEST_DEATH_TEST_USE_FORK=1: make gtest death tests valgrind-friendly

# When everyone has the latest valgrind, we might want to add

# --show-possible=no

@@ -108,10 +106,10 @@

G_SLICE=always-malloc \

NSS_DISABLE_ARENA_FREE_LIST=1 \

G_DEBUG=fatal_warnings \

+GTEST_DEATH_TEST_USE_FORK=1 \

valgrind \

--tool=$TOOL_NAME \

--trace-children=yes \

--suppressions="$SUPPRESSIONS" \

- --smc-check=all \

"${DEFAULT_TOOL_FLAGS[@]}" \

"$@"

« no previous file with comments | « no previous file | tools/valgrind/valgrind_test.py » ('j') | no next file with comments »