Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 335025: Handle the list of code-stub types using macro expansion (Closed)

Created:
11 years, 1 month ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Handle the list of code-stub types using macro expansion. As the list of code-stubs is used in two places it is now handled through a macro to keep this in sync. As some code-stubs is only used on ARM the list have been split into two parts to indicate this and get rid of dummy implementation on ia32 and x64 platforms. BUG=484 Committed: http://code.google.com/p/v8/source/detail?r=3127

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -86 lines) Patch
M src/arm/regexp-macro-assembler-arm.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +39 lines, -21 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +3 lines, -40 lines 0 comments Download
M src/heap.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/regexp-macro-assembler-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/regexp-macro-assembler.h View 1 chunk +0 lines, -16 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
The simple fix for 484 would of cause be to just add RegExpCEntry to the ...
11 years, 1 month ago (2009-10-26 12:10:43 UTC) #1
Mads Ager (chromium)
11 years, 1 month ago (2009-10-26 12:24:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698