Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 335024: Generalize the "aspacem" gtest filters for ThreadSanitizer on Mac (Closed)

Created:
11 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, Paweł Hajdan Jr., darin (slow to review)
Visibility:
Public.

Description

Wildcard the test cases if two or more tests make ThreadSanitizer hang. Usually, if several tests hang in the same way, that means there's some common code between them that makes TSAN's address space manager unhappy. Then it's likely that a new test from the same test case exploits the same code and breaks ThreadSanitizer again. BUG=http://code.google.com/p/data-race-test/issues/detail?id=11 TBR=dank Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M net/data/valgrind/net_unittests.gtest.txt View 1 chunk +0 lines, -1 line 0 comments Download
M net/data/valgrind/net_unittests.gtest-tsan_mac.txt View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
11 years, 1 month ago (2009-10-26 12:07:42 UTC) #1
dank
11 years, 1 month ago (2009-10-26 14:03:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698