Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: webkit/glue/webview_impl.cc

Issue 335019: Replace MessageLoop+ScopedRunnableMethodFactory with WebCore::Timer+Vector... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webframe_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webview_impl.cc
===================================================================
--- webkit/glue/webview_impl.cc (revision 29946)
+++ webkit/glue/webview_impl.cc (working copy)
@@ -199,7 +199,7 @@
}
virtual WebCore::String itemToolTip(unsigned last_index) const {
- NOTIMPLEMENTED();
+ notImplemented();
return WebCore::String();
}
@@ -301,9 +301,10 @@
WebCore::RenderStyle* style = text_field_->computedStyle();
if (!style) {
// It seems we can only have an NULL style in a TextField if the node is
- // dettached, in which case we the popup shoud not be showing.
- NOTREACHED() << "Please report this in http://crbug.com/7708 and include "
- "the page you were visiting.";
+ // dettached, in which case we the popup shoud not be showing. Please
+ // report this in http://crbug.com/7708 and include the page you were
+ // visiting.
+ ASSERT_NOT_REACHED();
}
return style;
}
@@ -664,12 +665,12 @@
autocomplete_popup_->selectedIndex() != -1) {
Node* node = GetFocusedNode();
if (!node || (node->nodeType() != WebCore::Node::ELEMENT_NODE)) {
- NOTREACHED();
+ ASSERT_NOT_REACHED();
return false;
}
WebCore::Element* element = static_cast<WebCore::Element*>(node);
if (!element->hasLocalName(WebCore::HTMLNames::inputTag)) {
- NOTREACHED();
+ ASSERT_NOT_REACHED();
return false;
}
@@ -1261,7 +1262,7 @@
break;
default:
- NOTIMPLEMENTED();
+ notImplemented();
break;
}
}
@@ -1702,7 +1703,7 @@
}
if (!focused_node->hasTagName(WebCore::HTMLNames::inputTag)) {
- NOTREACHED();
+ ASSERT_NOT_REACHED();
return;
}
« no previous file with comments | « webkit/glue/webframe_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698