Issue 335019: Replace MessageLoop+ScopedRunnableMethodFactory with WebCore::Timer+Vector...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 335019: Replace MessageLoop+ScopedRunnableMethodFactory with WebCore::Timer+Vector... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Replace MessageLoop+ScopedRunnableMethodFactory with WebCore::Timer+Vector This solution is clearly not as elegant, but it gets the job done, and it eliminates the last remaining base/ reference from webframe_impl.cc! R=dglazkov BUG=24608 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30035

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+94 lines, -35 lines)			Patch
M	webkit/glue/chrome_client_impl.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	webkit/glue/webframe_impl.h	View		5 chunks	+17 lines, -5 lines	0 comments	Download
M	webkit/glue/webframe_impl.cc	View	1 2	8 chunks	+66 lines, -20 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View		5 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages