Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 335016: Heap profiler improvements. (Closed)

Created:
11 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Heap profiler improvements. - account code objects in retainers profile; - differentiate between function boilerplates and closures; - simplify code; Committed: http://code.google.com/p/v8/source/detail?r=3124

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M src/heap.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap-profiler.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/heap-profiler.cc View 6 chunks +24 lines, -12 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
11 years, 2 months ago (2009-10-23 22:22:48 UTC) #1
Søren Thygesen Gjesse
http://codereview.chromium.org/335016/diff/1/5 File src/objects.cc (right): http://codereview.chromium.org/335016/diff/1/5#newcode1255 Line 1255: Heap::function_class_symbol() : Heap::closure_symbol(); Where will this show up? ...
11 years, 1 month ago (2009-10-26 08:13:09 UTC) #2
mnaganov (inactive)
http://codereview.chromium.org/335016/diff/1/5 File src/objects.cc (right): http://codereview.chromium.org/335016/diff/1/5#newcode1255 Line 1255: Heap::function_class_symbol() : Heap::closure_symbol(); On 2009/10/26 08:13:09, Søren Gjesse ...
11 years, 1 month ago (2009-10-26 09:54:14 UTC) #3
Søren Thygesen Gjesse
11 years, 1 month ago (2009-10-26 10:08:01 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698