Move creation of SEH frame into a separate funcion....

Move creation of SEH frame into a separate funcion.For any function that uses SEH, the compiler creates a single EXCEPTION_REGISTRATION record at the function prolog (even if the function has nested or inside condition statement __try/__except constructs). When __try block is entered and leaved only the index to the relevant scope table is updated.When the exception occurs the  __except_handler4 may ignore it if there is no scope table set i.e. we are outside __try block.In ChromeFrame when exception happens, the global vectored exception filter walks through the SEH chain and is misled that there is handler/filter installed and therefore skips creation of a crashdump.
BUG=23845
TEST=crashes in ChromeFrame background threads are reported.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30066

[darin (slow to review), 2009-10-23 20:51:40]

I'd like to defer this code review to Carlos.

[cpu_(ooo_6.6-7.5), 2009-10-23 21:46:22]

Consider __declspec(noinline) because if the compiler inlines your fix is
broken. I am almost positive that in WPO build it would be inlined.

Second, please fill the bug= and test= fields. In particular it would be nice to
have a bug in record about this,


On 2009/10/23 19:17:55, stoyan wrote:
>

[stoyan, 2009-10-23 23:31:24]

(noinline) and BUG/TEST added.
WPO did not inlined the code.

[cpu_(ooo_6.6-7.5), 2009-10-26 17:05:12]

LGTM