Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 335008: Use RtlCaptureContext instead of inline assembly to capture execution context... (Closed)

Created:
11 years, 2 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Use RtlCaptureContext instead of inline assembly to capture execution context on Windows Inline assembly is not available in Visual C++ 64-bit version so use RtlCaptureContext to capture execution context. RtlCaptureContext is not available on Windows 2000 so this change removes Windows 2000 support. If this turns up causing trouble we can revert to only use RtlCaptureContext in 64-bit and inline assembly in 32-bit. Committed: http://code.google.com/p/v8/source/detail?r=3122

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M src/platform-win32.cc View 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 2 months ago (2009-10-23 12:14:39 UTC) #1
Lasse Reichstein
11 years, 2 months ago (2009-10-23 12:39:42 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698