Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 335006: X64/Win64: Fix bug in returning ObjectPair. (Closed)

Created:
11 years, 2 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64/Win64: Fix bug in returning ObjectPair. Used the registers to test for failure before loading the result from the stack.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M src/x64/codegen-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Small review.
11 years, 2 months ago (2009-10-23 09:48:37 UTC) #1
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-23 10:40:44 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698