Issue 3350021: Generate GBB during factory instead of writing a prebuilt GBB.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3350021: Generate GBB during factory instead of writing a prebuilt GBB. (Closed)

Created:
10 years, 3 months ago by Tom Wai-Hong Tam

Modified:
9 years, 5 months ago

Reviewers:
Hung-Te, Nick Sanders, Tammo Spalink

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Generate GBB during factory instead of writing a prebuilt GBB. Currently we need to prebuild GBBs off-line according to the values (HWID, keys, and BMPFV) in component lists. During factory, it write the prebuilt GBB to BIOS. This CL is to generate the GBB during factory, not need to prebuild it. TEST=run factory_WriteGBB in factory test and reboot to see change.

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -59 lines)			Patch
	M	client/common_lib/gbb_util.py	View		3 chunks	+114 lines, -26 lines	0 comments	Download
	M	client/site_tests/factory_WriteGBB/factory_WriteGBB.py	View		1 chunk	+24 lines, -33 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hung-Te

LGTM with one comment http://codereview.chromium.org/3350021/diff/1/3 File client/site_tests/factory_WriteGBB/factory_WriteGBB.py (right): http://codereview.chromium.org/3350021/diff/1/3#newcode33 client/site_tests/factory_WriteGBB/factory_WriteGBB.py:33: keep_temp_files=True) any reason to force ...

10 years, 3 months ago (2010-09-13 08:09:04 UTC) #2

Tom Wai-Hong Tam

10 years, 3 months ago (2010-09-13 18:47:32 UTC) #3

http://codereview.chromium.org/3350021/diff/1/3
File client/site_tests/factory_WriteGBB/factory_WriteGBB.py (right):

http://codereview.chromium.org/3350021/diff/1/3#newcode33
client/site_tests/factory_WriteGBB/factory_WriteGBB.py:33: keep_temp_files=True)
Since updating GBB is risky. So want to keep the temporary data, like original
GBB, new GBB, keys and bmps to be written, etc. to a permanent preserve place
instead of /tmp which will be lost after reboot.

Expand Messages | Collapse Messages