Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 3348012: Enable webgl and accelerated compositing by default on all platforms. Removes... (Closed)

Created:
10 years, 3 months ago by Vangelis Kokkevis
Modified:
9 years, 6 months ago
CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Nico
Visibility:
Public.

Description

Enable webgl and accelerated compositing by default on all platforms. Removes --enable-webgl and --enable-accelerated-compositing flags and replaces them by --disable-webgl and --disable-accelerated-compositing. This CL is practically identical to: http://src.chromium.org/viewvc/chrome?view=rev&revision=58711 which was checked in the later reverted in: http://src.chromium.org/viewvc/chrome?view=rev&revision=58730 due to UI test failures related to video playback via the compositor. The main difference is that mac is no longer excluded so the two features are now turned on on all 3 platforms. The issue with the failing UI tests was corrected upstream in WebKit: http://trac.webkit.org/changeset/66923 so this WebKit change must be rolled in before the chromium change lands. BUG=54469 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58792

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/common/sandbox_init_wrapper_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/sandbox_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/render_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vangelis Kokkevis
Ken, do you mind taking another look at this one? I'm waiting for webkit to ...
10 years, 3 months ago (2010-09-08 00:11:47 UTC) #1
Ken Russell (switch to Gerrit)
10 years, 3 months ago (2010-09-08 00:17:03 UTC) #2
LGTM given that Nico thinks the compositor is robust enough to enable by default
on the Mac. With recent bug fixes it does appear to be more stable on various 3D
CSS demos. A couple of tiny formatting issues.

http://codereview.chromium.org/3348012/diff/1/4
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/3348012/diff/1/4#newcode121
chrome/common/chrome_switches.cc:121: const char
kDisableAcceleratedCompositing[]  =
Line up = with surrounding lines.

http://codereview.chromium.org/3348012/diff/1/4#newcode182
chrome/common/chrome_switches.cc:182: const char kDisableExperimentalWebGL[]    
  = "disable-webgl";
Line up = with surrounding lines.

Powered by Google App Engine
This is Rietveld 408576698