Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 3348004: Add suspend/resumeAnimations to the test_shell LayoutTestController... (Closed)

Created:
10 years, 3 months ago by Mihai Parparita -not on Chrome
Modified:
9 years, 6 months ago
Reviewers:
tony
CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Add suspend/resumeAnimations to the test_shell LayoutTestController implementation (introduced with http://trac.webkit.org/changeset/65107) TEST=animations/suspend-resume-animation.html BUG=51757 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58369

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M webkit/tools/test_shell/layout_test_controller.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/layout_test_controller.cc View 1 2 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mihai Parparita -not on Chrome
10 years, 3 months ago (2010-09-02 01:23:50 UTC) #1
tony
http://codereview.chromium.org/3348004/diff/6001/7002 File webkit/glue/dom_operations.h (right): http://codereview.chromium.org/3348004/diff/6001/7002#newcode121 webkit/glue/dom_operations.h:121: void ResumeAnimations(WebKit::WebView* view); Do we call these anywhere outside ...
10 years, 3 months ago (2010-09-02 01:29:05 UTC) #2
Mihai Parparita -not on Chrome
http://codereview.chromium.org/3348004/diff/6001/7002 File webkit/glue/dom_operations.h (right): http://codereview.chromium.org/3348004/diff/6001/7002#newcode121 webkit/glue/dom_operations.h:121: void ResumeAnimations(WebKit::WebView* view); On 2010/09/02 01:29:06, tony wrote: > ...
10 years, 3 months ago (2010-09-02 01:36:34 UTC) #3
Mihai Parparita -not on Chrome
10 years, 3 months ago (2010-09-02 01:45:36 UTC) #4
tony
10 years, 3 months ago (2010-09-02 02:25:15 UTC) #5
LGTM!

Powered by Google App Engine
This is Rietveld 408576698