Issue 3347016: Lock log files when reiniting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3347016: Lock log files when reiniting them. (Closed)

Created:
10 years, 3 months ago by DaveMoore

Modified:
9 years, 7 months ago

Reviewers:
stoyan

CC:
chromium-reviews, brettw-cc_chromium.org

Visibility:
Public.

Lock log files when reiniting them. This is a second attempt of this cl: http://codereview.chromium.org/3195014/show BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59439

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -100 lines)			Patch
	M	base/logging.cc	View	1	9 chunks	+148 lines, -100 lines	0 comments	Download

Total messages: 2 (0 generated)

DaveMoore

In response to the two comments from the prior cl: 1) The \\Global namespace was ...

10 years, 3 months ago (2010-09-07 20:56:02 UTC) #1

stoyan

10 years, 3 months ago (2010-09-08 16:55:18 UTC) #2

lgtm from me as long as NULL problem is fixed and this is just refactoring.