Moving file_util::FileInfo to base::PlatformFileInfo, and adding the...

Moving file_util::FileInfo to base::PlatformFileInfo, and adding the
last_accessed and creation_time fields.

BUG=none
TEST=none



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58454

[dumi, 2010-09-02 07:46:00]

typedef'ing file_util::FileInfo to base::PlatformFileInfo didn't quite work. if
i typedef it, then forward-declarations of file_util::FileInfo in other header
files fail. and if i try something like:

struct FileUtil : base::PlatformFileUtil {};

then converting from base::PlatformFileUtil* to file_util::FileUtil* fails.

[darin (slow to review), 2010-09-02 18:19:26]

LGTM w/ one nit:

http://codereview.chromium.org/3347005/diff/30001/25009
File base/platform_file.h (right):

http://codereview.chromium.org/3347005/diff/30001/25009#newcode80
base/platform_file.h:80: struct PlatformFileInfo {
IIRC, the plan is to add more functions to this header file one of which will
take PlatformFileInfo as a parameter.  we should avoid breaking up the flow of
functions with a struct definition, so how about putting this struct above the
CreatePlatformFile function?

(PassPlatformFile is declared at the bottom of this file since it is a utility
class that builds upon PlatformFile stuff.  I'd still keep it at the bottom.)

[dumi, 2010-09-02 19:25:48]

On 2010/09/02 18:19:26, darin wrote:
> LGTM w/ one nit:
> 
> http://codereview.chromium.org/3347005/diff/30001/25009
> File base/platform_file.h (right):
> 
> http://codereview.chromium.org/3347005/diff/30001/25009#newcode80
> base/platform_file.h:80: struct PlatformFileInfo {
> IIRC, the plan is to add more functions to this header file one of which will
> take PlatformFileInfo as a parameter.  we should avoid breaking up the flow of
> functions with a struct definition, so how about putting this struct above the
> CreatePlatformFile function?
> 
> (PassPlatformFile is declared at the bottom of this file since it is a utility
> class that builds upon PlatformFile stuff.  I'd still keep it at the bottom.)

moved.