Issue 3346006: NTP: Add transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3346006: NTP: Add transitions. (Closed)

Created:
10 years, 3 months ago by Aaron Boodman

Modified:
9 years, 6 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Visibility:
Public.

NTP: Add transitions. BUG=53978 TEST=Install an app. Expand and collapse sections. Things should swish. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58556

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -12 lines)			Patch
M	chrome/browser/resources/new_new_tab.css	View	1	4 chunks	+23 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/new_new_tab.js	View	2	6 chunks	+43 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/ntp/apps.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/resources/ntp/most_visited.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

arv (Not doing code reviews)

I'm concerned about tabbing here. When an element has display none you cannot use tab ...

10 years, 3 months ago (2010-09-03 16:06:04 UTC) #2

arv (Not doing code reviews)

That was meant as an LGTM with follow up changes.

10 years, 3 months ago (2010-09-03 16:06:27 UTC) #3

Aaron Boodman

I fixed the focus issues, along with a scrollbar flickering issue. This resulted in some ...

10 years, 3 months ago (2010-09-03 22:22:11 UTC) #4

LGTM