chrome/browser/renderer_host/test/test_render_view_host.cc - Issue 3346005: Don't create pending entries when a navigation is initiated by the page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/test/test_render_view_host.cc

Issue 3346005: Don't create pending entries when a navigation is initiated by the page. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/back_forward_menu_model_unittest.cc ('k') | chrome/browser/sessions/tab_restore_service_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/test/test_render_view_host.cc

diff --git a/chrome/browser/renderer_host/test/test_render_view_host.cc b/chrome/browser/renderer_host/test/test_render_view_host.cc

index 57ef915ecfeaa017237d1f2a82e309b1ac81449e..bca21e198922fa723ca39a51446cdf3ce34c4c5c 100644

--- a/chrome/browser/renderer_host/test/test_render_view_host.cc

+++ b/chrome/browser/renderer_host/test/test_render_view_host.cc

@@ -236,6 +236,8 @@ TestingProfile* RenderViewHostTestHarness::profile() {

}

MockRenderProcessHost* RenderViewHostTestHarness::process() {

+ if (pending_rvh())

+ return static_cast<MockRenderProcessHost*>(pending_rvh()->process());

return static_cast<MockRenderProcessHost*>(rvh()->process());

}

« no previous file with comments | « chrome/browser/back_forward_menu_model_unittest.cc ('k') | chrome/browser/sessions/tab_restore_service_browsertest.cc » ('j') | no next file with comments »