Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 3344008: Don't kill sdcards with boot_tries (Closed)

Created:
10 years, 3 months ago by Nick Sanders
Modified:
9 years, 7 months ago
Reviewers:
Bill Richardson
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Don't kill sdcards with boot_tries USB/SDCard boot devices typicaly don't run software updater, and won't have success ever set. We never want to try to fall back to the empty B partition either. The workaround for this is to set the successful bit regardless of actual boot success. bug=6395 Change-Id: I67c625804203b13be9a0c626c404fa38bafb5445

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename cgpt #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build_image View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nick Sanders
10 years, 3 months ago (2010-09-04 00:51:18 UTC) #1
Bill Richardson
One change, then LGTM. http://codereview.chromium.org/3344008/diff/1/2 File build_image (right): http://codereview.chromium.org/3344008/diff/1/2#newcode656 build_image:656: cgpt add -i 2 -S ...
10 years, 3 months ago (2010-09-04 00:58:20 UTC) #2
Nick Sanders
http://codereview.chromium.org/3344008/diff/1/2 File build_image (right): http://codereview.chromium.org/3344008/diff/1/2#newcode656 build_image:656: cgpt add -i 2 -S 1 "${OUTPUT_DIR}/${image_name}" On 2010/09/04 ...
10 years, 3 months ago (2010-09-04 01:14:00 UTC) #3
Bill Richardson
10 years, 3 months ago (2010-09-07 16:33:46 UTC) #4
LGTM. Thanks.

Powered by Google App Engine
This is Rietveld 408576698